Add CsWinRT projection #9976
Draft
Add CsWinRT projection #9976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to ESRP task V5 which eliminates secret usage. Parameter values to the task can be controlled by this library https://microsoft.visualstudio.com/WinUI/_apps/hub/ms.vss-distributed-task.hub-library?itemType=VariableGroups&view=VariableGroupView&variableGroupId=5612&path=WinUI2-Signing This currently points to WindowsAppSDK's ESRP configuration
microsoft-github-policy-service
bot
added
the
needs-triage
Sergio0694
suggested changes
Sep 11, 2024
Comment on lines
4
to
5
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> |
There was a problem hiding this comment.
We should remove these, especially Nullable. WinRT doesn't support annotations. #Resolved
| <Platform>AnyCPU</Platform> | ||
| <UseUwp>true</UseUwp> | ||
| <IsAotCompatible>true</IsAotCompatible> | ||
| <WindowsSdkPackageVersion>10.0.22621.37-preview</WindowsSdkPackageVersion> |
There was a problem hiding this comment.
Suggested change
| <WindowsSdkPackageVersion>10.0.22621.37-preview</WindowsSdkPackageVersion> | |
| <WindowsSdkPackageVersion>10.0.22621.39</WindowsSdkPackageVersion> | |
| ``` #Resolved |
| <Nullable>enable</Nullable> | ||
| <Platform>AnyCPU</Platform> | ||
| <UseUwp>true</UseUwp> | ||
| <IsAotCompatible>true</IsAotCompatible> |
There was a problem hiding this comment.
Also add
Suggested change
| <IsAotCompatible>true</IsAotCompatible> | |
| <DisableRuntimeMarshalling>true</DisableRuntimeMarshalling> | |
| ``` #Resolved |
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Windows.CSWinRT" Version="2.1.1" /> |
There was a problem hiding this comment.
Suggested change
| <PackageReference Include="Microsoft.Windows.CSWinRT" Version="2.1.1" /> | |
| <PackageReference Include="Microsoft.Windows.CSWinRT" Version="2.1.3" /> | |
| ``` #Resolved |
Comment on lines
18
to
20
| <PackageReference Include="Microsoft.Web.WebView2" Version="1.0.2739.15"> | ||
| <IncludeAssets>none</IncludeAssets> | ||
| </PackageReference> |
There was a problem hiding this comment.
Nit: can make this a one liner
Suggested change
| <PackageReference Include="Microsoft.Web.WebView2" Version="1.0.2739.15"> | |
| <IncludeAssets>none</IncludeAssets> | |
| </PackageReference> | |
| <PackageReference Include="Microsoft.Web.WebView2" Version="1.0.2739.15" IncludeAssets="none" /> | |
| ``` #Resolved |
Sergio0694
suggested changes
Sep 11, 2024
| <TargetFramework>net8.0-windows10.0.22621.0</TargetFramework> | ||
| <Platform>AnyCPU</Platform> | ||
| <UseUwp>true</UseUwp> | ||
| <DisableRuntimeMarshalling>true</DisableRuntimeMarshalling> |
There was a problem hiding this comment.
Wait, you also need IsAotCompatible 😅
I just meant delete the first two, not that one too, my bad. #Resolved
Sergio0694
suggested changes
Sep 13, 2024
| @@ -28,6 +28,8 @@ | |||
| <file target="lib\uap10.0\Microsoft.UI.Xaml\Themes" src="$BUILDOUTPUT$\$BUILDFLAVOR$\$BUILDARCH$\Microsoft.UI.Xaml\Generic.xaml"/> | |||
| <file target="lib\uap10.0\Design" src="$BUILDOUTPUT$\$BUILDFLAVOR$\$BUILDARCH$\Microsoft.UI.Xaml.Design\Microsoft.UI.Xaml.design.dll"/> | |||
|
|
|||
| <file target="lib\net8.0-windows10.0.22621.0\Microsoft.UI.Xaml.Projection.dll" src="$BUILDOUTPUT$\$BUILDFLAVOR$\$BUILDARCH$\Microsoft.UI.Xaml.Projection\Microsoft.UI.Xaml.Projection.dll" /> | |||
There was a problem hiding this comment.
We need to pack a few more things here. This is what the package looks like now:
We also need:
- The Generic.xaml file, in the same subfolder but under the new TFM
- The generated .xml file for the projections .dll
Not entirely sure what that Design.dll file is? Is it for the XAML Designer? I assume we need that one too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.